[PERF] Pass-through multithreaded_io flag in read_parquet #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
==========================================
+ Coverage 74.86% 74.89% +0.03%
==========================================
Files 60 60
Lines 6102 6102
==========================================
+ Hits 4568 4570 +2
+ Misses 1534 1532 -2
|
jaychia
added a commit
that referenced
this pull request
Oct 11, 2023
…thread (#1485) Updates default max_connections value from 64 to 8 Also renames `max_connections` in internal APIs to `max_connections_per_io_thread` to be more explicit, but keeps naming for external-facing APIs for backwards compatibility Note that the total number of connections being spawned for PyRunner is: `8.min(Num CPUs) * max_connections`, and theses are shared throughout the multithreaded backend The total number of connections being spawned for RayRunner after #1484 is: `num_ray_workers * 1 (sine we run single-threaded) * max_connections` --------- Co-authored-by: Jay Chia <[email protected]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes the
multithreaded_io=Falseflag through when running on the Ray Runner for read_parquet